Updated NSDate+Datetools category to reuse formatter instances. #13
Conversation
Updated NSDate+Datetools category to reuse formatter instances.
| @@ -1514,9 +1501,14 @@ -(NSString *)formattedDateWithFormat:(NSString *)format locale:(NSLocale *)local | |||
| * @return NSString representing the formatted date string | |||
| */ | |||
| -(NSString *)formattedDateWithFormat:(NSString *)format timeZone:(NSTimeZone *)timeZone locale:(NSLocale *)locale{ | |||
| NSDateFormatter *formatter = [[NSDateFormatter alloc] init]; | |||
| static NSDateFormatter *formatter = nil; | |||
There was a problem hiding this comment.
Sorry guys for saying this a little late, but this change makes this method thread-unsafe. Because NSDateFormatter is not thread safe, but NSDate is thread safe. Calling this method from different threads at the same time might cause an issue, because from the both threads the same NSDateFormatter object will be accessed.
Personally I use https://github.com/mysterioustrousers/MTDates for date calculations and this problem is solved there using locks. You could take a look at the implementation there.
There was a problem hiding this comment.
Good call. This, I believe, also extends to NSCalendar, which is used pervasively in the library. Feel free to raise an issue. Pull requests will be welcomed.
There was a problem hiding this comment.
@MatthewYork I'm sorry, I don't use this library now. I've noticed the library probably in cocoapods feed and started watching :) Unfortunately don't have enough of time to contribute to libraries I don't use, yet. I'm sorry.
Maybe I'll give this library a try on a next project in future ;)
There was a problem hiding this comment.
@yas375 I completely understand. I will create an issue and mark thread safety as an enhancement.
Cheers.
No description provided.